Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 220403008: Revert "Adding a mechanism to 'upgrade' the Dart type of elements" (Closed)

Created:
6 years, 8 months ago by blois
Modified:
6 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Revert "Adding a mechanism to 'upgrade' the Dart type of elements" This reverts commit 34615 because it's breaking some bots (not sure why). TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=34622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -554 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +27 lines, -80 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 5 chunks +66 lines, -114 lines 0 comments Download
D tests/html/custom/element_upgrade_test.dart View 1 chunk +0 lines, -132 lines 0 comments Download
D tests/html/custom/element_upgrade_test.html View 1 chunk +0 lines, -49 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/src/dart2js_CustomElementSupport.dart View 2 chunks +1 line, -58 lines 0 comments Download
D tools/dom/src/dartium_CustomElementSupport.dart View 1 chunk +0 lines, -89 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 2 chunks +39 lines, -3 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 2 chunks +1 line, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 2 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
6 years, 8 months ago (2014-04-01 22:44:43 UTC) #1
blois
6 years, 8 months ago (2014-04-01 23:00:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r34622 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698