Prevent test.dart warning "TestCase would be finished twice"

Prevent test.dart warning "TestCase would be finished twice"

BUG=
R=ricow@google.com, whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34638

[kustermann, 2014-04-01 23:38:14]

https://codereview.chromium.org/220243011/diff/1/dart/tools/testing/dart/test...
File dart/tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/220243011/diff/1/dart/tools/testing/dart/test...
dart/tools/testing/dart/test_runner.dart:2621: });
When this onDone is called, all remaining TestCase es will be marked as
finished. If we call '_completeTestCasesIfPossible()' afterwards again, this
will obviously lead to a clash.

Due to the async nature of dart, it can occur in certain cases that this
'onDone' is called before the NodeState.Processing ->
NodeState.Successfull/Failed StateChangeEvent was called. (see line 2626).

By adding this boolean here, we make sure we no longer respond to
StateChangeEvent's after we're done with all commands.

[ricow1, 2014-04-02 05:50:44]

lgtm

[Bill Hesse, 2014-04-02 07:52:54]

LGTM.

https://codereview.chromium.org/220243011/diff/1/dart/tools/testing/dart/test...
File dart/tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/220243011/diff/1/dart/tools/testing/dart/test...
dart/tools/testing/dart/test_runner.dart:2610: bool finishedRemainingTestCases =
false;
Should this member be private?  I don't see any uses outside the class (and
library).

[kustermann, 2014-04-02 08:01:57]

https://codereview.chromium.org/220243011/diff/1/dart/tools/testing/dart/test...
File dart/tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/220243011/diff/1/dart/tools/testing/dart/test...
dart/tools/testing/dart/test_runner.dart:2610: bool finishedRemainingTestCases =
false;
On 2014/04/02 07:52:54, Bill Hesse wrote:
> Should this member be private?  I don't see any uses outside the class (and
> library).

This is a variable inside a method/constructor, this is not a member.

[kustermann, 2014-04-02 08:05:26]

Committed patchset #1 manually as r34638 (presubmit successful).