Improve the mirror support for deferred loading.

Improve the mirror support for deferred loading by registering elements only included by mirror-usage seperately.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34685

[Johnni Winther, 2014-04-01 13:19:59]

lgtm

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/deferred_load.dart (right):

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:308: element =
element.implementation;
Remove this line.

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:452: (element as
ClassElement).resolutionState != STATE_DONE) {
Use `!isResolved` instead of `resolutionState != STATE_DONE`.

https://codereview.chromium.org/220203004/diff/1/tests/compiler/dart2js/defer...
File tests/compiler/dart2js/deferred_mirrors_test.dart (right):

https://codereview.chromium.org/220203004/diff/1/tests/compiler/dart2js/defer...
tests/compiler/dart2js/deferred_mirrors_test.dart:37: var foo2 =
lib2.find("foo2");
Shouldn't this be checked?

https://codereview.chromium.org/220203004/diff/1/tests/lib/mirrors/deferred_m...
File tests/lib/mirrors/deferred_mirrors_metadata_lib.dart (right):

https://codereview.chromium.org/220203004/diff/1/tests/lib/mirrors/deferred_m...
tests/lib/mirrors/deferred_mirrors_metadata_lib.dart:27: new F();
Why is this called?

[karlklose, 2014-04-01 13:48:17]

DBC:

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/compiler.dart:356: * Dependencies that
are only included due to mirrors.
Please add a todo to get rid of this (see above comment).

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/deferred_load.dart (right):

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:451: if
(element.isClass() &&
Consider using an is-test here, as you expect a subtype of ClassElement anyway.

[sigurdm, 2014-04-01 13:57:43]

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/compiler.dart:356: * Dependencies that
are only included due to mirrors.
On 2014/04/01 13:48:18, karlklose wrote:
> Please add a todo to get rid of this (see above comment).

Done.

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/deferred_load.dart (right):

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:308: element =
element.implementation;
On 2014/04/01 13:20:00, Johnni Winther wrote:
> Remove this line.

Done.

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:451: if
(element.isClass() &&
On 2014/04/01 13:48:18, karlklose wrote:
> Consider using an is-test here, as you expect a subtype of ClassElement
anyway.

Done.

https://codereview.chromium.org/220203004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:452: (element as
ClassElement).resolutionState != STATE_DONE) {
On 2014/04/01 13:20:00, Johnni Winther wrote:
> Use `!isResolved` instead of `resolutionState != STATE_DONE`.

Done.

https://codereview.chromium.org/220203004/diff/1/tests/compiler/dart2js/defer...
File tests/compiler/dart2js/deferred_mirrors_test.dart (right):

https://codereview.chromium.org/220203004/diff/1/tests/compiler/dart2js/defer...
tests/compiler/dart2js/deferred_mirrors_test.dart:37: var foo2 =
lib2.find("foo2");
On 2014/04/01 13:20:00, Johnni Winther wrote:
> Shouldn't this be checked?

Done.

https://codereview.chromium.org/220203004/diff/1/tests/lib/mirrors/deferred_m...
File tests/lib/mirrors/deferred_mirrors_metadata_lib.dart (right):

https://codereview.chromium.org/220203004/diff/1/tests/lib/mirrors/deferred_m...
tests/lib/mirrors/deferred_mirrors_metadata_lib.dart:27: new F();
On 2014/04/01 13:20:00, Johnni Winther wrote:
> Why is this called
Must have forgot to delete it.

[sigurdm, 2014-04-03 08:01:26]

Committed patchset #2 manually as r34685 (presubmit successful).