Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2201903004: add tool to get breakdown of deferred libraries by size (Closed)

Created:
4 years, 4 months ago by Harry Terkelsen
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart2js_info.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -38 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M README.md View 3 chunks +31 lines, -0 lines 0 comments Download
M bin/code_deps.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M bin/coverage_log_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M bin/debug_info.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M bin/deferred_library_check.dart View 2 chunks +1 line, -7 lines 0 comments Download
A bin/deferred_library_size.dart View 1 1 chunk +76 lines, -0 lines 0 comments Download
M bin/function_size_analysis.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M bin/library_size_split.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M bin/live_code_size_analysis.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/util.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -1 line 0 comments Download
M tool/travis.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
Visualizer coming after this
4 years, 4 months ago (2016-08-02 21:27:03 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2201903004/diff/1/bin/deferred_library_size.dart File bin/deferred_library_size.dart (right): https://codereview.chromium.org/2201903004/diff/1/bin/deferred_library_size.dart#newcode50 bin/deferred_library_size.dart:50: _printRow(importSize.import, importSize.size); were you also going to print ...
4 years, 4 months ago (2016-08-02 21:50:26 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/2201903004/diff/1/bin/deferred_library_size.dart File bin/deferred_library_size.dart (right): https://codereview.chromium.org/2201903004/diff/1/bin/deferred_library_size.dart#newcode50 bin/deferred_library_size.dart:50: _printRow(importSize.import, importSize.size); On 2016/08/02 21:50:26, Siggi Cherem (dart-lang) wrote: ...
4 years, 4 months ago (2016-08-02 21:57:49 UTC) #4
Harry Terkelsen
4 years, 4 months ago (2016-08-02 21:58:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
75d3e7b013ac305df616600dfebdcd160ece35ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698