Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 2200933002: Only run tests on the VM. (Closed)

Created:
4 years, 4 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/source_map_stack_trace.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only run tests on the VM. Now that we're using package_resolver, we aren't JS-compatible. R=jmesserly@google.com Committed: https://github.com/dart-lang/source_map_stack_trace/commit/b59b635262ca86d0a96bc6ff206e615d9b8490c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M .test_config View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 4 months ago (2016-08-02 00:13:50 UTC) #1
Jennifer Messerly
lgtm
4 years, 4 months ago (2016-08-02 00:14:48 UTC) #2
nweiz
4 years, 4 months ago (2016-08-02 00:25:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b59b635262ca86d0a96bc6ff206e615d9b8490c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698