Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219963020: [web_components] update web_components and polymer.js (Closed)

Created:
6 years, 8 months ago by Jennifer Messerly
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[web_components] update web_components and polymer.js R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34633

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+912 lines, -797 lines) Patch
M pkg/polymer/lib/src/js/polymer/build.log View 1 1 chunk +17 lines, -23 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.concat.js View 1 28 chunks +249 lines, -214 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.concat.js.map View 1 2 chunks +11 lines, -11 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.js.map View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/web_components/lib/build.log View 1 1 chunk +26 lines, -31 lines 0 comments Download
M pkg/web_components/lib/platform.js View 1 1 chunk +8 lines, -7 lines 0 comments Download
M pkg/web_components/lib/platform.concat.js View 1 102 chunks +598 lines, -508 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
Seems to pass all the tests I can run locally, hopefully no IE/Safari issues...
6 years, 8 months ago (2014-04-02 01:23:20 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/219963020/diff/1/pkg/web_components/lib/build.log File pkg/web_components/lib/build.log (right): https://codereview.chromium.org/219963020/diff/1/pkg/web_components/lib/build.log#newcode39 pkg/web_components/lib/build.log:39: can we add platform-dev? (Morgan had trouble figuring ...
6 years, 8 months ago (2014-04-02 01:27:54 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/219963020/diff/1/pkg/web_components/lib/build.log File pkg/web_components/lib/build.log (right): https://codereview.chromium.org/219963020/diff/1/pkg/web_components/lib/build.log#newcode39 pkg/web_components/lib/build.log:39: On 2014/04/02 01:27:55, Siggi Cherem (dart-lang) wrote: > can ...
6 years, 8 months ago (2014-04-02 01:36:29 UTC) #3
Jennifer Messerly
6 years, 8 months ago (2014-04-02 01:36:47 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r34633 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698