Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2199183002: Support running tests without a packages/ directory. (Closed)

Created:
4 years, 4 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Bob Nystrom, kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add an annotation to quiet the analyzer. #

Total comments: 3

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -42 lines) Patch
M lib/src/barback/pub_package_provider.dart View 1 7 chunks +45 lines, -41 lines 0 comments Download
M pubspec.yaml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/test_pub.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
nweiz
4 years, 4 months ago (2016-08-02 00:53:13 UTC) #1
kevmoo
DBQ https://codereview.chromium.org/2199183002/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2199183002/diff/20001/pubspec.yaml#newcode45 pubspec.yaml:45: test: {path: ../pkg/test} Uh...so this will only work ...
4 years, 4 months ago (2016-08-02 03:14:12 UTC) #3
Bob Nystrom
Aside from the dependency_override thing, LGTM! https://codereview.chromium.org/2199183002/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2199183002/diff/20001/pubspec.yaml#newcode45 pubspec.yaml:45: test: {path: ../pkg/test} ...
4 years, 4 months ago (2016-08-02 15:58:05 UTC) #4
nweiz
Code review changes
4 years, 4 months ago (2016-08-02 23:26:42 UTC) #5
nweiz
https://codereview.chromium.org/2199183002/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2199183002/diff/20001/pubspec.yaml#newcode45 pubspec.yaml:45: test: {path: ../pkg/test} On 2016/08/02 15:58:05, Bob Nystrom wrote: ...
4 years, 4 months ago (2016-08-02 23:26:42 UTC) #6
nweiz
4 years, 4 months ago (2016-08-02 23:27:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
9bdeeb7d076762dd4abc67f5a412c0fdb8ceb07c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698