Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 21986002: Add Dart_GetNativeReceiver to special case access to the native field (Closed)

Created:
7 years, 4 months ago by siva
Modified:
7 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add Dart_GetNativeReceiver to special case access to the native field of a receiver argument (helps eliminate number of validity checks). R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25750

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -11 lines) Patch
M runtime/include/dart_api.h View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 1 2 chunks +7 lines, -11 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 4 months ago (2013-08-02 21:36:07 UTC) #1
srdjan
lgtm
7 years, 4 months ago (2013-08-02 22:12:14 UTC) #2
siva
7 years, 4 months ago (2013-08-02 22:47:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25750 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698