Format parameter lists with trailing commas like argument lists.

Format parameter lists with trailing commas like argument lists.

Fix #447.

R=jakemac@google.com

Committed: https://github.com/dart-lang/dart_style/commit/2a66a281eddb743792ad0a30900ff7df80a11f65

[Bob Nystrom, 2016-07-29 21:37:47]

rnystrom@google.com changed reviewers:
+ jakemac@google.com

[jakemac, 2016-07-29 21:57:06]

lgtm

https://codereview.chromium.org/2196863002/diff/1/lib/src/source_visitor.dart
File lib/src/source_visitor.dart (right):

https://codereview.chromium.org/2196863002/diff/1/lib/src/source_visitor.dart...
lib/src/source_visitor.dart:2038: assert(parameters.parameters.isNotEmpty);
or possibly assert(node.parameters.last.endToken.next.type == TokenType.COMMA)?

[Bob Nystrom, 2016-07-29 22:18:26]

https://codereview.chromium.org/2196863002/diff/1/lib/src/source_visitor.dart
File lib/src/source_visitor.dart (right):

https://codereview.chromium.org/2196863002/diff/1/lib/src/source_visitor.dart...
lib/src/source_visitor.dart:2038: assert(parameters.parameters.isNotEmpty);
On 2016/07/29 21:57:05, jakemac wrote:
> or possibly assert(node.parameters.last.endToken.next.type ==
TokenType.COMMA)?

I could assert that too, but it felt a bit gratuitous to me. I'm asserting the
list isn't empty mainly because we call ".first" on it below, which will throw
an exception if the list is empty. If there isn't a trailing comma, we shouldn't
get here, but it should still do the right thing.

[Bob Nystrom, 2016-07-29 22:18:35]

Description was changed from

==========
Format parameter lists with trailing commas like argument lists.

Fix #447.
==========

to

==========
Format parameter lists with trailing commas like argument lists.

Fix #447.

R=jakemac@google.com

Committed:
https://github.com/dart-lang/dart_style/commit/2a66a281eddb743792ad0a30900ff7...
==========

[Bob Nystrom, 2016-07-29 22:18:39]

Committed patchset #1 (id:1) manually as
2a66a281eddb743792ad0a30900ff7df80a11f65 (presubmit successful).