Issue 219663002: Test for deferred prefix dependent code invalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219663002: Test for deferred prefix dependent code invalidation (Closed)

Created:
6 years, 8 months ago by hausner

Modified:
6 years, 8 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Test for deferred prefix dependent code invalidation Checks that an optimized method that contains code referring to an unloaded prefix is properly invalidated. R=iposva@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34567

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
	A	tests/language/deferred_load_inval_code_lib.dart	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	A	tests/language/deferred_load_inval_code_test.dart	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwTR -ip https://codereview.chromium.org/219663002/diff/1/tests/language/deferred_load_inval_code_test.dart File tests/language/deferred_load_inval_code_test.dart (right): https://codereview.chromium.org/219663002/diff/1/tests/language/deferred_load_inval_code_test.dart#newcode36 tests/language/deferred_load_inval_code_test.dart:36: loaded = true; Tab!

6 years, 8 months ago (2014-03-31 17:37:04 UTC) #2

hausner

6 years, 8 months ago (2014-03-31 18:15:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34567 (presubmit successful).

Expand Messages | Collapse Messages