Display notification when build is done.

Display notification when build is done.

For now, only works on Mac and Linux.

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34593

[ahe, 2014-03-31 16:52:37]

I've updated this CL a few times based on feedback from Martin. Please make sure
you have seen the latest patch set.

[ricow1, 2014-04-01 07:59:49]

lgtm

https://codereview.chromium.org/219513003/diff/40001/dart/tools/build.py
File dart/tools/build.py (right):

https://codereview.chromium.org/219513003/diff/40001/dart/tools/build.py#newc...
dart/tools/build.py:307: 
this may be a good place to do a
sys.stdout.flush()
to make sure we get this in the right location for annotated steps based builds
on windows (I am not a 100% sure this is necessary, since this script will exit
right after)

https://codereview.chromium.org/219513003/diff/40001/dart/tools/build.py#newc...
dart/tools/build.py:312: title = build_config
why do we put this into a local variable?

https://codereview.chromium.org/219513003/diff/40001/dart/tools/build.py#newc...
dart/tools/build.py:319: command = "osascript -e '%s' &" % script
I would just remove the command variable and branch at the end and run os.system
(or subprocess.call) here directly, easier to follow flow then IMHO (and below
for linux)

[ahe, 2014-04-01 12:11:07]

Thank you, Rico!

https://codereview.chromium.org/219513003/diff/40001/dart/tools/build.py
File dart/tools/build.py (right):

https://codereview.chromium.org/219513003/diff/40001/dart/tools/build.py#newc...
dart/tools/build.py:307: 
On 2014/04/01 07:59:49, ricow1 wrote:
> this may be a good place to do a
> sys.stdout.flush()
> to make sure we get this in the right location for annotated steps based
builds
> on windows (I am not a 100% sure this is necessary, since this script will
exit
> right after)

Done. I agree this is a good place, just as a precaution.

https://codereview.chromium.org/219513003/diff/40001/dart/tools/build.py#newc...
dart/tools/build.py:312: title = build_config
On 2014/04/01 07:59:49, ricow1 wrote:
> why do we put this into a local variable?

Because it more clearly describes that this will be used as the title of the
dialog. I don't think that it is obvious that the title should be a string like
"ReleaseIA32".

https://codereview.chromium.org/219513003/diff/40001/dart/tools/build.py#newc...
dart/tools/build.py:319: command = "osascript -e '%s' &" % script
On 2014/04/01 07:59:49, ricow1 wrote:
> I would just remove the command variable and branch at the end and run
os.system
> (or subprocess.call) here directly, easier to follow flow then IMHO (and below
> for linux)

I had that originally, but then I had to repeat the comment about ignoring the
return code.

[ahe, 2014-04-01 12:11:54]

Committed patchset #4 manually as r34593 (presubmit successful).