Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 219493003: Revert "Add support for closure calls through getters." (Closed)

Created:
6 years, 8 months ago by floitsch
Modified:
6 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Add support for closure calls through getters." This reverts commit r4555. Committed: https://code.google.com/p/dart/source/detail?r=34556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -210 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/lib/js_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 9 chunks +82 lines, -167 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +5 lines, -8 lines 0 comments Download
M tests/lib/mirrors/invoke_call_through_getter_previously_accessed_test.dart View 3 chunks +10 lines, -10 lines 0 comments Download
M tests/lib/mirrors/invoke_call_through_getter_test.dart View 3 chunks +10 lines, -10 lines 0 comments Download
M tests/lib/mirrors/invoke_call_through_implicit_getter_previously_accessed_test.dart View 3 chunks +10 lines, -10 lines 0 comments Download
M tests/lib/mirrors/invoke_closurization_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
TBR.
6 years, 8 months ago (2014-03-31 15:21:07 UTC) #1
floitsch
Committed patchset #1 manually as r34556 (presubmit successful).
6 years, 8 months ago (2014-03-31 15:21:35 UTC) #2
karlklose
6 years, 8 months ago (2014-03-31 18:23:16 UTC) #3
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698