Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 219473007: Deferred prefix support in metadata (Closed)

Created:
6 years, 8 months ago by hausner
Modified:
6 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Deferred prefix support in metadata Deferred prefixes are never ok in metadata, since metadata is required to be compile time constant. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=34601

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M runtime/vm/parser.cc View 1 2 chunks +12 lines, -2 lines 0 comments Download
M tests/language/deferred_constraints_constants_test.dart View 1 2 chunks +7 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
6 years, 8 months ago (2014-03-31 23:23:54 UTC) #1
rmacnak
LGTM
6 years, 8 months ago (2014-04-01 00:35:36 UTC) #2
hausner
6 years, 8 months ago (2014-04-01 16:11:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34601 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698