Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 219433004: Fix mirror_loader to detect whether the type is a generic class. (Closed)

Created:
6 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix mirror_loader to detect whether the type is a generic class. BUG=https://code.google.com/p/dart/issues/detail?id=17929 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=34610

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -7 lines) Patch
M pkg/pkg.status View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/mirror_loader.dart View 2 chunks +9 lines, -1 line 0 comments Download
A pkg/polymer/test/mirror_loader_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A + pkg/polymer/test/mirror_loader_test.html View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
6 years, 8 months ago (2014-04-01 16:59:30 UTC) #1
Jennifer Messerly
lgtm
6 years, 8 months ago (2014-04-01 18:22:32 UTC) #2
Siggi Cherem (dart-lang)
6 years, 8 months ago (2014-04-01 19:07:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34610 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698