Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 21938002: Avoid creating unnecessary port in slave config, and don't print the messages (Closed)

Created:
7 years, 4 months ago by gram
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Avoid creating unnecessary port in slave config, and don't print the messages used by the test harness. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=25737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pkg/unittest/test/unittest_test_utils.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
7 years, 4 months ago (2013-08-02 17:21:08 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 4 months ago (2013-08-02 17:25:57 UTC) #2
gram
7 years, 4 months ago (2013-08-02 17:30:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25737 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698