Issue 219333008: Allow configuring build directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219333008: Allow configuring build directory. (Closed)

Created:
6 years, 8 months ago by Bob Nystrom

Modified:
6 years, 8 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow configuring build directory. BUG=https://code.google.com/p/dart/issues/detail?id=16840 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=34581

Patch Set 2 : Fix year. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -21 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/command/build.dart	View		5 chunks	+10 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/io.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	sdk/lib/_internal/pub/test/build/can_specify_output_directory_test.dart	View	1	1 chunk	+15 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/219333008/diff/1/sdk/lib/_internal/pub/test/build/can_specify_output_directory_test.dart File sdk/lib/_internal/pub/test/build/can_specify_output_directory_test.dart (right): https://codereview.chromium.org/219333008/diff/1/sdk/lib/_internal/pub/test/build/can_specify_output_directory_test.dart#newcode1 sdk/lib/_internal/pub/test/build/can_specify_output_directory_test.dart:1: // Copyright (c) 2013, the Dart project authors. ...

6 years, 8 months ago (2014-03-31 21:33:51 UTC) #2

Bob Nystrom

Committed patchset #2 manually as r34581 (presubmit successful).

6 years, 8 months ago (2014-03-31 23:20:39 UTC) #3

Bob Nystrom

6 years, 8 months ago (2014-03-31 23:21:29 UTC) #4

Message was sent while issue was closed.

Thanks!

https://codereview.chromium.org/219333008/diff/1/sdk/lib/_internal/pub/test/b...
File sdk/lib/_internal/pub/test/build/can_specify_output_directory_test.dart
(right):

https://codereview.chromium.org/219333008/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/can_specify_output_directory_test.dart:1: //
Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS d.file
On 2014/03/31 21:33:51, nweiz wrote:
> 2014

Done.

Expand Messages | Collapse Messages

Issue 219333008: Allow configuring build directory. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix year. #

Messages