Issue 219333005: Record the dependency of a implicit constructor to its superclass.

Issue 219333005: Record the dependency of a implicit constructor to its superclass. (Closed)

Created:
6 years, 8 months ago by sigurdm

Modified:
6 years, 8 months ago

Reviewers:
Johnni Winther, karlklose, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Record the dependency of a implicit constructor to its superclass. This lets deferred loading find the classes. BUG= dartbug.com/Issue 17930 R=floitsch@google.com, johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=34587

Patch Set 3 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -2 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/world.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart	View	1 2	1 chunk	+116 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

karlklose

DBC: https://codereview.chromium.org/219333005/diff/1/sdk/lib/_internal/compiler/implementation/universe/universe.dart File sdk/lib/_internal/compiler/implementation/universe/universe.dart (right): https://codereview.chromium.org/219333005/diff/1/sdk/lib/_internal/compiler/implementation/universe/universe.dart#newcode106 sdk/lib/_internal/compiler/implementation/universe/universe.dart:106: void registerImplicitSuperCall(TreeElements elements, This should be recorded in ...

6 years, 8 months ago (2014-03-31 14:10:15 UTC) #2

sigurdm

https://codereview.chromium.org/219333005/diff/1/sdk/lib/_internal/compiler/implementation/universe/universe.dart File sdk/lib/_internal/compiler/implementation/universe/universe.dart (right): https://codereview.chromium.org/219333005/diff/1/sdk/lib/_internal/compiler/implementation/universe/universe.dart#newcode106 sdk/lib/_internal/compiler/implementation/universe/universe.dart:106: void registerImplicitSuperCall(TreeElements elements, On 2014/03/31 14:10:15, karlklose wrote: > ...

6 years, 8 months ago (2014-03-31 14:26:59 UTC) #3

floitsch

On 2014/03/31 14:51:32, floitsch wrote: > LGTM. Please add bug-number to description.

6 years, 8 months ago (2014-03-31 14:51:47 UTC) #5

Johnni Winther

lgtm https://codereview.chromium.org/219333005/diff/20001/tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart File tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart (right): https://codereview.chromium.org/219333005/diff/20001/tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart#newcode35 tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart:35: .then((_) => test(compiler))); Most of this code could ...

6 years, 8 months ago (2014-04-01 05:46:20 UTC) #6

sigurdm

https://codereview.chromium.org/219333005/diff/20001/tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart File tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart (right): https://codereview.chromium.org/219333005/diff/20001/tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart#newcode35 tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart:35: .then((_) => test(compiler))); On 2014/04/01 05:46:21, Johnni Winther wrote: ...

6 years, 8 months ago (2014-04-01 07:36:03 UTC) #7

sigurdm

6 years, 8 months ago (2014-04-01 08:10:59 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r34587 (presubmit successful).

Expand Messages | Collapse Messages