Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2192883003: Gracefully handle IO errors when failing to overwrite a file. (Closed)

Created:
4 years, 4 months ago by Bob Nystrom
Modified:
4 years, 4 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gracefully handle IO errors when failing to overwrite a file. Fix #473. R=nweiz@google.com Committed: https://github.com/dart-lang/dart_style/commit/2b4d8df72089cc8ac237c34bb0287f3d9eedae9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/formatter_options.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M test/io_test.dart View 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 4 months ago (2016-07-28 20:51:54 UTC) #2
nweiz
lgtm
4 years, 4 months ago (2016-07-28 21:02:32 UTC) #3
Bob Nystrom
4 years, 4 months ago (2016-07-28 21:22:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b4d8df72089cc8ac237c34bb0287f3d9eedae9f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698