Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219283008: pkg/shelf (Closed)

Created:
6 years, 8 months ago by kevmoo
Modified:
6 years, 8 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org, ahe, ricow1
Visibility:
Public.

Description

pkg/shelf Copied from https://github.com/kevmoo/shelf.dart/ At v0.3.0+4, commit 1a2607d1d2524d5632fa4624e2a7529c42a1a8fd R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=34611

Patch Set 1 #

Total comments: 7

Patch Set 2 : cl nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3098 lines, -10 lines) Patch
M pkg/pkg.status View 1 3 chunks +8 lines, -7 lines 0 comments Download
A pkg/shelf/CHANGELOG.md View 1 1 chunk +31 lines, -0 lines 0 comments Download
A + pkg/shelf/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A pkg/shelf/README.md View 1 1 chunk +42 lines, -0 lines 0 comments Download
A pkg/shelf/example/example_server.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A + pkg/shelf/lib/shelf.dart View 1 chunk +7 lines, -4 lines 0 comments Download
A pkg/shelf/lib/shelf_io.dart View 1 chunk +103 lines, -0 lines 0 comments Download
A pkg/shelf/lib/src/handler.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/shelf/lib/src/handlers/logger.dart View 1 chunk +78 lines, -0 lines 0 comments Download
A pkg/shelf/lib/src/media_type.dart View 1 chunk +156 lines, -0 lines 0 comments Download
A pkg/shelf/lib/src/message.dart View 1 chunk +95 lines, -0 lines 0 comments Download
A pkg/shelf/lib/src/middleware.dart View 1 chunk +63 lines, -0 lines 0 comments Download
A pkg/shelf/lib/src/request.dart View 1 chunk +107 lines, -0 lines 0 comments Download
A pkg/shelf/lib/src/response.dart View 1 chunk +273 lines, -0 lines 0 comments Download
A pkg/shelf/lib/src/stack.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A pkg/shelf/lib/src/string_scanner.dart View 1 chunk +69 lines, -0 lines 0 comments Download
A pkg/shelf/lib/src/util.dart View 1 chunk +158 lines, -0 lines 0 comments Download
A pkg/shelf/pubspec.yaml View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/shelf/test/create_middleware_test.dart View 1 chunk +211 lines, -0 lines 0 comments Download
A pkg/shelf/test/harness_console.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A pkg/shelf/test/http_date_test.dart View 1 chunk +315 lines, -0 lines 0 comments Download
A pkg/shelf/test/log_middleware_test.dart View 1 chunk +61 lines, -0 lines 0 comments Download
A pkg/shelf/test/media_type_test.dart View 1 chunk +163 lines, -0 lines 0 comments Download
A pkg/shelf/test/request_test.dart View 1 chunk +150 lines, -0 lines 0 comments Download
A pkg/shelf/test/response_test.dart View 1 chunk +234 lines, -0 lines 0 comments Download
A pkg/shelf/test/shelf_io_test.dart View 1 chunk +217 lines, -0 lines 0 comments Download
A pkg/shelf/test/stack_test.dart View 1 chunk +91 lines, -0 lines 0 comments Download
A pkg/shelf/test/string_scanner_test.dart View 1 chunk +266 lines, -0 lines 0 comments Download
A pkg/shelf/test/test_util.dart View 1 chunk +32 lines, -0 lines 0 comments Download
A pkg/shelf/tool/hop_runner.dart View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kevmoo
6 years, 8 months ago (2014-04-01 03:46:15 UTC) #1
kevmoo
FYI https://codereview.chromium.org/219283008/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/219283008/diff/1/pkg/pkg.status#newcode228 pkg/pkg.status:228: shelf/test/shelf_io_test: Fail, OK # Uses dart:io This is ...
6 years, 8 months ago (2014-04-01 03:47:36 UTC) #2
nweiz
lgtm
6 years, 8 months ago (2014-04-01 19:12:14 UTC) #3
nweiz
https://codereview.chromium.org/219283008/diff/1/pkg/shelf/README.md File pkg/shelf/README.md (right): https://codereview.chromium.org/219283008/diff/1/pkg/shelf/README.md#newcode1 pkg/shelf/README.md:1: #Shelf This is unnecessary. https://codereview.chromium.org/219283008/diff/1/pkg/shelf/changelog.md File pkg/shelf/changelog.md (right): https://codereview.chromium.org/219283008/diff/1/pkg/shelf/changelog.md#newcode1 ...
6 years, 8 months ago (2014-04-01 19:13:11 UTC) #4
kevmoo
https://codereview.chromium.org/219283008/diff/1/pkg/shelf/README.md File pkg/shelf/README.md (right): https://codereview.chromium.org/219283008/diff/1/pkg/shelf/README.md#newcode1 pkg/shelf/README.md:1: #Shelf On 2014/04/01 19:13:11, nweiz wrote: > This is ...
6 years, 8 months ago (2014-04-01 19:24:04 UTC) #5
kevmoo
Committed patchset #2 manually as r34611 (presubmit successful).
6 years, 8 months ago (2014-04-01 19:24:34 UTC) #6
ahe
What is the purpose of this package? Why is it included in the Dart SDK ...
6 years, 8 months ago (2014-04-01 20:16:54 UTC) #7
nweiz
6 years, 8 months ago (2014-04-01 20:20:12 UTC) #8
Message was sent while issue was closed. 
On 2014/04/01 20:16:54, ahe wrote:
> What is the purpose of this package?

It's a middleware framework for server-side applications.

> Why is it included in the Dart SDK sources?

It's going to be used by pub and packages that pub uses.

> Why is it included in api.dartlang.org?

I believe all packages in the SDK are included on api.dartlang.org by default.

Powered by Google App Engine
This is Rietveld 408576698