Issue 219263003: Add end-to-end test for consistency in source map file and js file.

Issue 219263003: Add end-to-end test for consistency in source map file and js file. (Closed)

Created:
6 years, 8 months ago by zarah

Modified:
6 years, 8 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add end-to-end test for consistency in source map file and js file. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=34642

Patch Set 2 : Added support for windows and an additional test for pub serve. #

Patch Set 3 : Removed pub serve test. #

Total comments: 2

Patch Set 4 : Addressed comment. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -0 lines)			Patch
A	tests/compiler/dart2js/source_map_consistency_helper.dart	View	1 2 3	1 chunk	+54 lines, -0 lines	0 comments	Download
A	tests/compiler/dart2js/source_map_d2js_consistency_test.dart	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
A	tests/compiler/dart2js/source_map_pub_build_consistency_test.dart	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/219263003/diff/40001/tests/compiler/dart2js/source_map_consistency_helper.dart File tests/compiler/dart2js/source_map_consistency_helper.dart (right): https://codereview.chromium.org/219263003/diff/40001/tests/compiler/dart2js/source_map_consistency_helper.dart#newcode39 tests/compiler/dart2js/source_map_consistency_helper.dart:39: File newFile = element.copySync(newPath); It seems we don't ...

6 years, 8 months ago (2014-04-02 08:43:30 UTC) #4

zarah

https://codereview.chromium.org/219263003/diff/40001/tests/compiler/dart2js/source_map_consistency_helper.dart File tests/compiler/dart2js/source_map_consistency_helper.dart (right): https://codereview.chromium.org/219263003/diff/40001/tests/compiler/dart2js/source_map_consistency_helper.dart#newcode39 tests/compiler/dart2js/source_map_consistency_helper.dart:39: File newFile = element.copySync(newPath); On 2014/04/02 08:43:30, Johnni Winther ...

6 years, 8 months ago (2014-04-02 08:58:49 UTC) #5

zarah

6 years, 8 months ago (2014-04-02 09:30:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r34642 (presubmit successful).

Expand Messages | Collapse Messages