Deprecate automatic generation of precompiled.js.

Deprecate automatic generation of precompiled.js.

RELNOTES=Deprecate automatic generation of precompiled.js from dart2js.
R=floitsch@google.com, ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34637

[floitsch, 2014-03-31 12:53:26]

LGTM (with discussion comment).

https://codereview.chromium.org/219053003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
(right):

https://codereview.chromium.org/219053003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:1553:
'release. Use the --csp option to generate the precompiled.js output\\n' +
space at end of line?

https://codereview.chromium.org/219053003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:1553:
'release. Use the --csp option to generate the precompiled.js output\\n' +
Should we generate "precompiled.js" or generate to the output-file that is
requested?
That is, should --out=foo.js be the precompiled file, when using --csp ?

[Johnni Winther, 2014-04-01 08:20:21]

https://codereview.chromium.org/219053003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
(right):

https://codereview.chromium.org/219053003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:1553:
'release. Use the --csp option to generate the precompiled.js output\\n' +
On 2014/03/31 12:53:26, floitsch wrote:
> space at end of line?

Removed.

https://codereview.chromium.org/219053003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:1553:
'release. Use the --csp option to generate the precompiled.js output\\n' +
On 2014/03/31 12:53:26, floitsch wrote:
> Should we generate "precompiled.js" or generate to the output-file that is
> requested?
> That is, should --out=foo.js be the precompiled file, when using --csp ?

Done.

[Johnni Winther, 2014-04-01 08:20:31]

PTAL

[ricow1, 2014-04-01 08:34:35]

You need to change
tools/testing/dart/compiler_configuration.dart as well

[Johnni Winther, 2014-04-01 10:33:43]

PTAL

[ricow1, 2014-04-01 10:37:58]

lgtm with comment

https://codereview.chromium.org/219053003/diff/40001/tools/testing/dart/compi...
File tools/testing/dart/compiler_configuration.dart (right):

https://codereview.chromium.org/219053003/diff/40001/tools/testing/dart/compi...
tools/testing/dart/compiler_configuration.dart:251: String normalOutput =
'$tempDir/out.js';
just inline the string

https://codereview.chromium.org/219053003/diff/40001/tools/testing/dart/test_...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/219053003/diff/40001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:346: var csp = configuration['csp'] ? '-csp'
: '';
there is no need to add this here now right?

[floitsch, 2014-04-01 11:09:45]

LGTM once Rico's comments are addressed.

[Johnni Winther, 2014-04-01 13:52:34]

https://codereview.chromium.org/219053003/diff/40001/tools/testing/dart/compi...
File tools/testing/dart/compiler_configuration.dart (right):

https://codereview.chromium.org/219053003/diff/40001/tools/testing/dart/compi...
tools/testing/dart/compiler_configuration.dart:251: String normalOutput =
'$tempDir/out.js';
On 2014/04/01 10:37:58, ricow1 wrote:
> just inline the string

Done.

https://codereview.chromium.org/219053003/diff/40001/tools/testing/dart/test_...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/219053003/diff/40001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:346: var csp = configuration['csp'] ? '-csp'
: '';
On 2014/04/01 10:37:58, ricow1 wrote:
> there is no need to add this here now right?

Apparently not.

[Johnni Winther, 2014-04-02 06:00:28]

Committed patchset #4 manually as r34637 (presubmit successful).

[karlklose, 2014-04-03 07:38:23]

This changes seems to cause the timeouts on dart2js-drt-linux-csp-be.