Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 21905005: pkg/unittest: get stackTrace from error directly (Closed)

Created:
7 years, 4 months ago by kevmoo-old
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/unittest: get stackTrace from error directly

Patch Set 1 #

Patch Set 2 : note on related issue #

Patch Set 3 : delegating TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M pkg/unittest/lib/src/test_case.dart View 1 2 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kevmoo-old
Wondering if getAttachedStackTrace should do this for us? Hmm...
7 years, 4 months ago (2013-08-04 20:15:13 UTC) #1
gram
lgtm but you may want to open an issue for this to be folded into ...
7 years, 4 months ago (2013-08-05 16:49:22 UTC) #2
kevmoo-old
On 2013/08/05 16:49:22, gram wrote: > lgtm but you may want to open an issue ...
7 years, 4 months ago (2013-08-05 16:59:35 UTC) #3
gram
On 2013/08/05 16:59:35, kevmoo wrote: > On 2013/08/05 16:49:22, gram wrote: > > lgtm but ...
7 years, 4 months ago (2013-08-05 17:01:44 UTC) #4
kevmoo-old
7 years, 4 months ago (2013-08-05 18:21:55 UTC) #5
Committed patchset #3 manually as r25779

Powered by Google App Engine
This is Rietveld 408576698