Issue 218993003: Emit read-modify-write of fields as assignment op.

Issue 218993003: Emit read-modify-write of fields as assignment op. (Closed)

Created:
6 years, 8 months ago by sra1

Modified:
6 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, dart2js-team_google.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Emit read-modify-write of fields as assignment op. Best improvements are swarm at 0.32% smaller, DeltaBlue 0.42% smaller; a little over half of that after minification and/or gzip. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=34614

Patch Set 1 : #

Total comments: 4

Patch Set 2 : add test #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+294 lines, -1 line)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart	View	1	2 chunks	+113 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View		3 chunks	+54 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/tracer.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	tests/compiler/dart2js/field_update_test.dart	View	1	1 chunk	+97 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

A few tests would be nice. Otherwise LGTM. https://codereview.chromium.org/218993003/diff/80001/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart (right): https://codereview.chromium.org/218993003/diff/80001/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart#newcode144 sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart:144: // ...

6 years, 8 months ago (2014-04-01 17:28:57 UTC) #2

sra1

https://codereview.chromium.org/218993003/diff/80001/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart (right): https://codereview.chromium.org/218993003/diff/80001/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart#newcode144 sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart:144: // t1 = x.f; t2 = t1 + 1; ...

6 years, 8 months ago (2014-04-01 19:51:59 UTC) #3

sra1

6 years, 8 months ago (2014-04-01 20:11:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34614 (presubmit successful).

Expand Messages | Collapse Messages