Enables unboxed mints in ia32 javascript int compatability mode.

Enables unboxed mints in ia32 javascript int compatability mode.

Also checks range information before emitting checks on x64.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25740

[srdjan, 2013-08-02 18:07:22]

LGTM with comments

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:1080: if
(FLAG_throw_on_javascript_int_overflow) return true;
Instead of the architecture specific ifdef you could check the size of the Smi
instead.

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_ia32.cc:656: if
(FLAG_throw_on_javascript_int_overflow) {
I would move this test at call sites, think it is mode readable.
if (FLAG_throw_on_javascript_int_overflow) {
  EmitJavascriptIntOverflowCheck(..)
}

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_x64.cc (right):

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_x64.cc:2159:
!range->IsWithin(-0x20000000000000LL, 0x20000000000000LL)) {
Ditto for if (FLAG_throw_on_javascript_int_overflow)

[zra, 2013-08-02 18:30:26]

Thanks!

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:1080: if
(FLAG_throw_on_javascript_int_overflow) return true;
On 2013/08/02 18:07:22, srdjan wrote:
> Instead of the architecture specific ifdef you could check the size of the Smi
> instead.

Done.

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_ia32.cc:656: if
(FLAG_throw_on_javascript_int_overflow) {
On 2013/08/02 18:07:22, srdjan wrote:
> I would move this test at call sites, think it is mode readable.
> if (FLAG_throw_on_javascript_int_overflow) {
>   EmitJavascriptIntOverflowCheck(..)
> }

Done.

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_x64.cc (right):

https://codereview.chromium.org/21885003/diff/2/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_x64.cc:2159:
!range->IsWithin(-0x20000000000000LL, 0x20000000000000LL)) {
On 2013/08/02 18:07:22, srdjan wrote:
> Ditto for if (FLAG_throw_on_javascript_int_overflow)

Done.

[zra, 2013-08-02 18:37:24]

Committed patchset #3 manually as r25740 (presubmit successful).