Cleanup vm_service library loading.

Cleanup vm_service library loading.

BUG=11927
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25744

[Cutch, 2013-08-02 18:39:08]

Ready for review

[siva, 2013-08-02 21:32:44]

lgtm

https://codereview.chromium.org/21880004/diff/3001/runtime/bin/vmservice_impl.cc
File runtime/bin/vmservice_impl.cc (right):

https://codereview.chromium.org/21880004/diff/3001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.cc:297: (strcmp(kVMServiceLibraryName, url_string) ==
0);
This seems to be computed too eagerly. Is is needed only
if tag is Dart_kImportTag, you could move this down under
that case statement.

Also it might be more readable to have functions
bool IsVMServiceURL(const char* url_string);
bool IsVMServiceLibrary(const char* url_string);
and use them instead.

[Cutch, 2013-08-02 21:39:13]

https://codereview.chromium.org/21880004/diff/3001/runtime/bin/vmservice_impl.cc
File runtime/bin/vmservice_impl.cc (right):

https://codereview.chromium.org/21880004/diff/3001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.cc:297: (strcmp(kVMServiceLibraryName, url_string) ==
0);
On 2013/08/02 21:32:44, siva wrote:
> This seems to be computed too eagerly. Is is needed only
> if tag is Dart_kImportTag, you could move this down under
> that case statement.
> 
> Also it might be more readable to have functions
> bool IsVMServiceURL(const char* url_string);
> bool IsVMServiceLibrary(const char* url_string);
> and use them instead.

Done.

[Cutch, 2013-08-02 21:40:19]

Committed patchset #4 manually as r25744 (presubmit successful).