Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 218783002: Updated markdown library. (Closed)

Created:
6 years, 8 months ago by caffinatedmonkey
Modified:
6 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updated markdown library. This patch fixes an issue which caused dartanalyzer warnings. R=kevmoo@google.com BUG= https://code.google.com/p/dart/issues/detail?id=17896 Committed: https://code.google.com/p/dart/source/detail?r=34583

Patch Set 1 #

Patch Set 2 : Updated pkg/pkg.status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M pkg/docgen/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/pkg.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/pkg/markdown/lib/src/inline_parser.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/pkg/markdown/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
caffinatedmonkey
6 years, 8 months ago (2014-03-30 23:04:56 UTC) #1
kevmoo
Nit: add a space after BUG= so the link works. Removed line 148 from pkg/pkg.status: ...
6 years, 8 months ago (2014-03-31 01:50:20 UTC) #2
caffinatedmonkey
On 2014/03/31 01:50:20, kevmoo wrote: > Nit: add a space after BUG= so the link ...
6 years, 8 months ago (2014-03-31 18:56:08 UTC) #3
kevmoo
On 2014/03/31 18:56:08, caffinatedmonkey wrote: > On 2014/03/31 01:50:20, kevmoo wrote: > > Nit: add ...
6 years, 8 months ago (2014-03-31 20:42:36 UTC) #4
caffinatedmonkey
On 2014/03/31 20:42:36, kevmoo wrote: > On 2014/03/31 18:56:08, caffinatedmonkey wrote: > > On 2014/03/31 ...
6 years, 8 months ago (2014-03-31 23:36:48 UTC) #5
kevmoo
lgtm
6 years, 8 months ago (2014-04-01 00:02:27 UTC) #6
kevmoo
6 years, 8 months ago (2014-04-01 00:03:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r34583 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698