Issue 21876005: Fixes obo error in javascript int checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21876005: Fixes obo error in javascript int checking. (Closed)

Created:
7 years, 4 months ago by zra

Modified:
7 years, 4 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -54 lines)			Patch
M	runtime/lib/integers.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	10 chunks	+16 lines, -21 lines	0 comments	Download
M	runtime/vm/object.cc	View	5 chunks	+8 lines, -11 lines	0 comments	Download
M	tests/standalone/javascript_int_overflow_literal_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/standalone/javascript_int_overflow_test.dart	View	4 chunks	+18 lines, -18 lines	0 comments	Download

Total messages: 4 (0 generated)

zra

I am on vacation next week. If this is still not in agreement with javascript, ...

7 years, 4 months ago (2013-08-02 15:29:33 UTC) #1

zra

Committed patchset #1 manually as r25733 (presubmit successful).

7 years, 4 months ago (2013-08-02 16:06:51 UTC) #3

Message was sent while issue was closed.

Thanks! LGTM as well.