Enforce a blank line after local function declarations.

Enforce a blank line after local function declarations.

R=nweiz@google.com

Committed: https://github.com/dart-lang/dart_style/commit/8b5aa7e9d090def190d4ae44a21c9d689928935f

[Bob Nystrom, 2016-07-28 20:07:51]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2016-07-28 21:00:45]

lgtm

https://codereview.chromium.org/2186343003/diff/1/lib/src/source_visitor.dart
File lib/src/source_visitor.dart (left):

https://codereview.chromium.org/2186343003/diff/1/lib/src/source_visitor.dart...
lib/src/source_visitor.dart:2164: void _writeBody(Token leftBracket, Token
rightBracket,
Why not keep `_writeBody` and just define it in terms of [_beginBody] and
[_endBody]?

https://codereview.chromium.org/2186343003/diff/1/lib/src/source_visitor.dart
File lib/src/source_visitor.dart (right):

https://codereview.chromium.org/2186343003/diff/1/lib/src/source_visitor.dart...
lib/src/source_visitor.dart:279: var body =
statement.functionDeclaration.functionExpression.body as BlockFunctionBody;
Long lines.

If you assign `body` outside the inner if statement, you can avoid the cast here
since the `is` check will propagate.

[nweiz, 2016-07-28 21:01:44]

Oh also: should this get a changelog entry?

[Bob Nystrom, 2016-07-28 21:26:31]

On 2016/07/28 21:01:44, nweiz wrote:
> Oh also: should this get a changelog entry?

Yes, oops! Done.

[Bob Nystrom, 2016-07-28 21:27:35]

Description was changed from

==========
Enforce a blank line after local function declarations.
==========

to

==========
Enforce a blank line after local function declarations.

R=nweiz@google.com

Committed:
https://github.com/dart-lang/dart_style/commit/8b5aa7e9d090def190d4ae44a21c9d...
==========

[Bob Nystrom, 2016-07-28 21:27:37]

Committed patchset #2 (id:20001) manually as
8b5aa7e9d090def190d4ae44a21c9d689928935f (presubmit successful).

[Bob Nystrom, 2016-07-28 21:27:51]

https://codereview.chromium.org/2186343003/diff/1/lib/src/source_visitor.dart
File lib/src/source_visitor.dart (left):

https://codereview.chromium.org/2186343003/diff/1/lib/src/source_visitor.dart...
lib/src/source_visitor.dart:2164: void _writeBody(Token leftBracket, Token
rightBracket,
On 2016/07/28 21:00:45, nweiz wrote:
> Why not keep `_writeBody` and just define it in terms of [_beginBody] and
> [_endBody]?

I could, but it's only used in like two other places so it doesn't really
justify having a helper for it. Also, in one of the places, I found the big
nested function literal actually harder to read.

https://codereview.chromium.org/2186343003/diff/1/lib/src/source_visitor.dart
File lib/src/source_visitor.dart (right):

https://codereview.chromium.org/2186343003/diff/1/lib/src/source_visitor.dart...
lib/src/source_visitor.dart:279: var body =
statement.functionDeclaration.functionExpression.body as BlockFunctionBody;
On 2016/07/28 21:00:45, nweiz wrote:
> Long lines.

Done.

> If you assign `body` outside the inner if statement, you can avoid the cast
here
> since the `is` check will propagate.

Done.