pkg/http v0.10.0

pkg/http v0.10.0

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34577

[kevmoo, 2014-03-31 19:53:34]

I want to roll Shelf forward to these changes and do one more release before
brining it into the SDK.

[nweiz, 2014-03-31 20:05:39]

https://codereview.chromium.org/218623008/diff/1/pkg/http/CHANGELOG.md
File pkg/http/CHANGELOG.md (left):

https://codereview.chromium.org/218623008/diff/1/pkg/http/CHANGELOG.md#oldcode8
pkg/http/CHANGELOG.md:8: 
I don't understand why you're changing my formatting here. It makes it much
harder to read.

https://codereview.chromium.org/218623008/diff/1/pkg/http/CHANGELOG.md
File pkg/http/CHANGELOG.md (right):

https://codereview.chromium.org/218623008/diff/1/pkg/http/CHANGELOG.md#newcode1
pkg/http/CHANGELOG.md:1: # Changelog - http
This is redundant. The changelog is primarily visible on pub.dartlang.org, and
that already has headers that provide this information.

https://codereview.chromium.org/218623008/diff/1/pkg/http/CHANGELOG.md#newcode5
pkg/http/CHANGELOG.md:5: * **BREAKING** Make `BaseRequest.contentLength` and
`BaseResponse.contentLength` use `null`
Is there a style guide for changelogs? If we're going to enforce things like
annotating breaking change declarations, it would be nice to have a place where
those conventions are documented.

https://codereview.chromium.org/218623008/diff/1/pkg/http/CHANGELOG.md#newcode7
pkg/http/CHANGELOG.md:7: * **BREAKING** The `contentLength` parameter to `new
BaseResponse` is now named rather than
Long lines.

[kevmoo, 2014-03-31 20:17:21]

PTAL

Just did the markdown list tweak.

Agreed with the rest. We should discuss the changelog formatting.

https://codereview.chromium.org/218623008/diff/1/pkg/http/CHANGELOG.md
File pkg/http/CHANGELOG.md (left):

https://codereview.chromium.org/218623008/diff/1/pkg/http/CHANGELOG.md#oldcode8
pkg/http/CHANGELOG.md:8: 
On 2014/03/31 20:05:39, nweiz wrote:
> I don't understand why you're changing my formatting here. It makes it much
> harder to read.

Not when it goes through the markdown parser. GitHub breaks these into separate
lists.

[nweiz, 2014-03-31 20:29:36]

https://codereview.chromium.org/218623008/diff/1/pkg/http/CHANGELOG.md
File pkg/http/CHANGELOG.md (left):

https://codereview.chromium.org/218623008/diff/1/pkg/http/CHANGELOG.md#oldcode8
pkg/http/CHANGELOG.md:8: 
On 2014/03/31 20:17:21, kevmoo wrote:
> On 2014/03/31 20:05:39, nweiz wrote:
> > I don't understand why you're changing my formatting here. It makes it much
> > harder to read.
> 
> Not when it goes through the markdown parser. GitHub breaks these into
separate
> lists.

That's not true: https://gist.github.com/nex3/94b9bb285068895aabde

[kevmoo, 2014-03-31 20:39:40]

PTAL

[nweiz, 2014-03-31 21:28:00]

lgtm

I assume you're planning on publishing this?

[kevmoo, 2014-03-31 21:31:03]

Committed patchset #3 manually as r34577 (presubmit successful).