Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 218273002: Upgrading tests with unittest deprecations (Closed)

Created:
6 years, 9 months ago by kevmoo
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -263 lines) Patch
M tests/benchmark_smoke/benchmark_smoke_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/canvas_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/canvasrenderingcontext2d_test.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/html/cssstyledeclaration_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/event_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/events_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/html/filereader_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/html/form_data_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/history_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_2_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/html/isolates_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/keyboard_event_test.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M tests/html/native_gc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/request_animation_frame_test.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M tests/html/transition_event_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/url_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/wheelevent_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/worker_api_test.dart View 1 chunk +1 line, -1 line 1 comment Download
M tests/html/worker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/xhr_cross_origin_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/xhr_test.dart View 8 chunks +10 lines, -10 lines 0 comments Download
M tests/isolate/browser/compute_this_script_browser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/browser/typed_data_message_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/count_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/cross_isolate_message_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/illegal_msg_function_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/isolate/illegal_msg_mirror_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/isolate/isolate_complex_messages_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/mandel_isolate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/message2_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/isolate/message_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/isolate/mint_maker_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/isolate/nested_spawn2_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/isolate/port_test.dart View 1 chunk +1 line, -1 line 2 comments Download
M tests/isolate/raw_port_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/isolate/request_reply_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/spawn_function_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_multi_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_nested_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/stacktrace_message_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/static_function_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/isolate/unresolved_ports_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib/async/first_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/future_timeout_test.dart View 15 chunks +15 lines, -15 lines 0 comments Download
M tests/lib/async/multiple_timer_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/lib/async/schedule_microtask2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/schedule_microtask3_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/lib/async/schedule_microtask5_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 25 chunks +37 lines, -37 lines 0 comments Download
M tests/lib/async/stream_first_where_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_from_iterable_test.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/lib/async/stream_iterator_test.dart View 4 chunks +13 lines, -13 lines 0 comments Download
M tests/lib/async/stream_join_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/lib/async/stream_last_where_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic5_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_single_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/lib/async/stream_single_to_multi_subscriber_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/lib/async/stream_state_helper.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/lib/async/stream_subscription_as_future_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/lib/async/stream_timeout_test.dart View 11 chunks +13 lines, -13 lines 0 comments Download
M tests/lib/async/stream_transform_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/lib/async/timer_cancel1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/async/timer_cancel2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_cancel_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/lib/async/timer_isActive_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/async/timer_isolate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_repeat_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/light_unittest.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kevmoo
Basically a find-replace. Tests pass.
6 years, 9 months ago (2014-03-29 05:56:42 UTC) #1
ricow1
+siggi LGTM
6 years, 8 months ago (2014-03-31 06:42:47 UTC) #2
Siggi Cherem (dart-lang)
LGTM https://codereview.chromium.org/218273002/diff/1/tests/html/worker_api_test.dart File tests/html/worker_api_test.dart (right): https://codereview.chromium.org/218273002/diff/1/tests/html/worker_api_test.dart#newcode30 tests/html/worker_api_test.dart:30: .then(expectAsync((reply) => expect(reply, equals('Hello from Worker')))); I know ...
6 years, 8 months ago (2014-03-31 17:13:33 UTC) #3
kevmoo
https://codereview.chromium.org/218273002/diff/1/tests/isolate/port_test.dart File tests/isolate/port_test.dart (right): https://codereview.chromium.org/218273002/diff/1/tests/isolate/port_test.dart#newcode12 tests/isolate/port_test.dart:12: import '../../pkg/matcher/lib/matcher.dart'; On 2014/03/31 17:13:34, Siggi Cherem (dart-lang) wrote: ...
6 years, 8 months ago (2014-03-31 18:33:00 UTC) #4
kevmoo
6 years, 8 months ago (2014-03-31 18:34:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r34569 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698