Always split collections and argument lists with trailing commas.

Always split collections and argument lists with trailing commas.

This preserves the users intention that a trailing comma means, "make
this easy to edit each element on its own line". It also means argument
lists with trailing commas are formatted similar to collections:

fn(
  arg,
  arg,
);

R=nweiz@google.com

Committed: https://github.com/dart-lang/dart_style/commit/ad69e8a8a31776a33bbcb0cd9bb9c0afeeede09e

[Bob Nystrom, 2016-07-25 17:55:59]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2016-07-25 22:29:06]

lgtm

https://codereview.chromium.org/2181743002/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2181743002/diff/1/CHANGELOG.md#newcode11
CHANGELOG.md:11: * Always split collection literals that contain a trailing
comma.
And argument lists?

https://codereview.chromium.org/2181743002/diff/1/lib/src/source_visitor.dart
File lib/src/source_visitor.dart (right):

https://codereview.chromium.org/2181743002/diff/1/lib/src/source_visitor.dart...
lib/src/source_visitor.dart:152: _visitCollectionLiteral(null,
node.leftParenthesis, node.arguments, node.rightParenthesis);
Long line.

[Bob Nystrom, 2016-07-26 21:22:08]

https://codereview.chromium.org/2181743002/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2181743002/diff/1/CHANGELOG.md#newcode11
CHANGELOG.md:11: * Always split collection literals that contain a trailing
comma.
On 2016/07/25 22:29:06, nweiz wrote:
> And argument lists?

Done.

https://codereview.chromium.org/2181743002/diff/1/lib/src/source_visitor.dart
File lib/src/source_visitor.dart (right):

https://codereview.chromium.org/2181743002/diff/1/lib/src/source_visitor.dart...
lib/src/source_visitor.dart:152: _visitCollectionLiteral(null,
node.leftParenthesis, node.arguments, node.rightParenthesis);
On 2016/07/25 22:29:06, nweiz wrote:
> Long line.

Ironically, I forgot to format. Done.

[Bob Nystrom, 2016-07-26 21:33:01]

Description was changed from

==========
Always split collections and argument lists with trailing commas.

This preserves the users intention that a trailing comma means, "make
this easy to edit each element on its own line". It also means argument
lists with trailing commas are formatted similar to collections:

fn(
  arg,
  arg,
);
==========

to

==========
Always split collections and argument lists with trailing commas.

This preserves the users intention that a trailing comma means, "make
this easy to edit each element on its own line". It also means argument
lists with trailing commas are formatted similar to collections:

fn(
  arg,
  arg,
);

R=nweiz@google.com

Committed:
https://github.com/dart-lang/dart_style/commit/ad69e8a8a31776a33bbcb0cd9bb9c0...
==========

[Bob Nystrom, 2016-07-26 21:33:03]

Committed patchset #2 (id:20001) manually as
ad69e8a8a31776a33bbcb0cd9bb9c0afeeede09e (presubmit successful).