- Make ports be less predictable.

- Make ports be less predictable.
- Limit the range of port numbers to 30-bits.
- Parse the ports as 64-bit values when reading from the wire in the debugger protocol.

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34542

[Ivan Posva, 2014-03-28 22:23:45]

Most of this CL has already been reviewed as part of
https://codereview.chromium.org/198463007

Changes include:
- Limit the range to 30 bits for port numbers to avoid any integer parsing
overflows in the debugger protocol.
- Corrected condition for loop when allocating ports.
- Parsing a 64-bit number for isolate id, although that is really a noop at the
moment.

Thanks,
-Ivan

[hausner, 2014-03-28 23:27:30]

LGTM.

https://codereview.chromium.org/217693002/diff/1/runtime/vm/port.cc
File runtime/vm/port.cc (right):

https://codereview.chromium.org/217693002/diff/1/runtime/vm/port.cc#newcode71
runtime/vm/port.cc:71: while ((result == 0) || (FindPort(result) >= 0)) {
You could turn this into a do { } while() loop.

[Ivan Posva, 2014-03-28 23:39:25]

Thanks,
-Ivan

https://codereview.chromium.org/217693002/diff/1/runtime/vm/port.cc
File runtime/vm/port.cc (right):

https://codereview.chromium.org/217693002/diff/1/runtime/vm/port.cc#newcode71
runtime/vm/port.cc:71: while ((result == 0) || (FindPort(result) >= 0)) {
On 2014/03/28 23:27:30, hausner wrote:
> You could turn this into a do { } while() loop.

I tried to write it as an repeat-until, but that somehow did not work.

[Ivan Posva, 2014-03-28 23:39:41]

Committed patchset #1 manually as r34542 (presubmit successful).