VM: Evaluate metadata on a class in the scope of its library not the scope of the class.

VM: Evaluate metadata on a class in the scope of its library not the scope of the class.

BUG=http://dartbug.com/17795
R=gbracha@google.com, hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34537

[gbracha, 2014-03-28 21:40:50]

test lgtm

[hausner, 2014-03-28 22:25:33]

LGTM

https://codereview.chromium.org/217543004/diff/20001/tests/lib/mirrors/metada...
File tests/lib/mirrors/metadata_scope_test.dart (right):

https://codereview.chromium.org/217543004/diff/20001/tests/lib/mirrors/metada...
tests/lib/mirrors/metadata_scope_test.dart:16: @Annotation(foo)  /// 01:
compile-time error
Maybe a comment why this is a compile-time error? Is it because there is no
compile-time constant foo at top-level?

https://codereview.chromium.org/217543004/diff/20001/tests/lib/mirrors/metada...
tests/lib/mirrors/metadata_scope_test.dart:36: @Annotation(baz)
Comment to note that the baz in the metadata should resolve to the top-level
function, not the one in the class.

[rmacnak, 2014-03-28 22:36:57]

https://codereview.chromium.org/217543004/diff/20001/tests/lib/mirrors/metada...
File tests/lib/mirrors/metadata_scope_test.dart (right):

https://codereview.chromium.org/217543004/diff/20001/tests/lib/mirrors/metada...
tests/lib/mirrors/metadata_scope_test.dart:16: @Annotation(foo)  /// 01:
compile-time error
On 2014/03/28 22:25:33, hausner wrote:
> Maybe a comment why this is a compile-time error? Is it because there is no
> compile-time constant foo at top-level?

Done

https://codereview.chromium.org/217543004/diff/20001/tests/lib/mirrors/metada...
tests/lib/mirrors/metadata_scope_test.dart:36: @Annotation(baz)
On 2014/03/28 22:25:33, hausner wrote:
> Comment to note that the baz in the metadata should resolve to the top-level
> function, not the one in the class.

Done

[rmacnak, 2014-03-28 22:38:39]

Committed patchset #3 manually as r34537 (presubmit successful).