Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2174913002: Add an SDK source. (Closed)

Created:
4 years, 5 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an SDK source. Currently Flutter is the only supported SDK. Closes #1431 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/c9fb0d3697d7fa2efce914143eeaa63fb1abd9dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -1 line) Patch
M lib/src/flutter.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A lib/src/source/sdk.dart View 1 chunk +109 lines, -0 lines 0 comments Download
M lib/src/source_registry.dart View 3 chunks +6 lines, -1 line 0 comments Download
M lib/src/system_cache.dart View 2 chunks +4 lines, -0 lines 0 comments Download
A test/sdk_test.dart View 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 5 months ago (2016-07-22 18:44:34 UTC) #1
Bob Nystrom
lgtm
4 years, 4 months ago (2016-07-25 20:57:19 UTC) #2
nweiz
4 years, 4 months ago (2016-07-25 22:34:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c9fb0d3697d7fa2efce914143eeaa63fb1abd9dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698