Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2173623002: Allow command ArgParsers to be overridden. (Closed)

Created:
4 years, 5 months ago by nweiz
Modified:
4 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/args@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow command ArgParsers to be overridden. This didn't work in strong mode, since they were declared as fields. R=rnystrom@google.com Committed: https://github.com/dart-lang/args/commit/1054fa7fb5b657ecb8f7b0a9d587b26ce8f67dec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/command_runner.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 5 months ago (2016-07-22 01:09:32 UTC) #1
Bob Nystrom
lgtm
4 years, 5 months ago (2016-07-22 17:40:19 UTC) #2
nweiz
4 years, 5 months ago (2016-07-22 18:41:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1054fa7fb5b657ecb8f7b0a9d587b26ce8f67dec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698