Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2172883002: Add validation for Flutter constraints. (Closed)

Created:
4 years, 5 months ago by nweiz
Modified:
4 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add validation for Flutter constraints. Packages with Flutter constraints should only be published with SDK constraints that restrict the SDK to versions that support Flutter constraints. Closes #1432 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/7d06cb506a40129bc9fda9c1fc343696923047af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -17 lines) Patch
M lib/src/validator/sdk_constraint.dart View 2 chunks +34 lines, -10 lines 0 comments Download
M test/validator/sdk_constraint_test.dart View 1 chunk +61 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 5 months ago (2016-07-22 00:46:10 UTC) #1
Bob Nystrom
lgtm
4 years, 5 months ago (2016-07-22 17:39:48 UTC) #2
nweiz
4 years, 5 months ago (2016-07-22 18:43:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d06cb506a40129bc9fda9c1fc343696923047af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698