Refactor version_solver_test.

Refactor version_solver_test.

This brings these tests in line with others, making them integration
tests that invoke a pub process rather than testing the version solver
APIs directly. This will make it easier to add Flutter support in the
future (see #1431 and #1432).

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/a1a247064507621a9a719963f9dd823be7733724

[Bob Nystrom, 2016-07-21 18:03:52]

What does this do to the performance of the test? A big reason I made it a unit
test was because it was much faster to execute.

[nweiz, 2016-07-21 19:59:38]

On 2016/07/21 18:03:52, Bob Nystrom wrote:
> What does this do to the performance of the test? A big reason I made it a
unit
> test was because it was much faster to execute.

It's certainly slower—it takes about a minute now. But it was a substantial
maintenance burden before when adding any new solver functionality, and piling
up mocks upon mocks isn't really in line with the rest of our testing
philosophy. Ultimately 1m when run in parallel with other tests doesn't add a
significant amount of time to pub's overall test corpus, and this will make
iteration much easier.

[Bob Nystrom, 2016-07-21 20:17:24]

LGTM!

[nweiz, 2016-07-21 20:46:54]

Description was changed from

==========
Refactor version_solver_test.

This brings these tests in line with others, making them integration
tests that invoke a pub process rather than testing the version solver
APIs directly. This will make it easier to add Flutter support in the
future (see #1431 and #1432).

R=rnystrom@google.com
==========

to

==========
Refactor version_solver_test.

This brings these tests in line with others, making them integration
tests that invoke a pub process rather than testing the version solver
APIs directly. This will make it easier to add Flutter support in the
future (see #1431 and #1432).

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/pub/commit/a1a247064507621a9a719963f9dd823be7733724
==========

[nweiz, 2016-07-21 20:46:56]

Committed patchset #1 (id:1) manually as
a1a247064507621a9a719963f9dd823be7733724 (presubmit successful).