Code transformers fixes for latest analyzer update

Code transformers fixes for latest analyzer update

This fixes some incompatibilities with the newest analyzer around how deleted files are handled. The resolver was removing the source completely, but the analyzer expects the source to remain as long as it is being referenced by a URI.

This also fixes an issue where resolver were not being released when an exception was thrown from within the applyResolvers call.

** NOTE ** see the commented line which needs to be removed with the updated analyzer.

BUG=
R=brianwilkerson@google.com, scheglov@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34512

[blois, 2014-03-28 18:08:08]

https://codereview.chromium.org/217163005/diff/20001/pkg/code_transformers/te...
File pkg/code_transformers/test/resolver_test.dart (right):

https://codereview.chromium.org/217163005/diff/20001/pkg/code_transformers/te...
pkg/code_transformers/test/resolver_test.dart:186: 'error: absolute paths not
allowed: "/b.dart"',
This test will fail on the new analyzer, to fix it remove this second error
message (it's a dupe of the first, but was getting reported twice).

[Brian Wilkerson, 2014-03-28 18:20:51]

LGTM! Thanks for the prompt turn-around!

https://codereview.chromium.org/217163005/diff/20001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolver_impl.dart (right):

https://codereview.chromium.org/217163005/diff/20001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:333: new
TimestampedData<String>(modificationStamp, _contents);
This method should throw an exception if _contents is null.

[scheglov, 2014-03-28 18:24:25]

lgtm

[blois, 2014-03-28 18:29:04]

https://codereview.chromium.org/217163005/diff/20001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolver_impl.dart (right):

https://codereview.chromium.org/217163005/diff/20001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:333: new
TimestampedData<String>(modificationStamp, _contents);
On 2014/03/28 18:20:52, Brian Wilkerson wrote:
> This method should throw an exception if _contents is null.

Done.

[Siggi Cherem (dart-lang), 2014-03-28 18:34:16]

lgtm!

[blois, 2014-03-28 18:36:44]

Committed patchset #3 manually as r34512 (presubmit successful).