Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 217153002: pkg/analysis_server: fixes for unittest deprecations (Closed)

Created:
6 years, 9 months ago by kevmoo
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/analysis_server: fixes for unittest deprecations R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=34503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/channel_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_context_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
6 years, 9 months ago (2014-03-28 16:03:29 UTC) #1
danrubel
lgtm
6 years, 9 months ago (2014-03-28 16:08:35 UTC) #2
kevmoo
Committed patchset #1 manually as r34503 (presubmit successful).
6 years, 9 months ago (2014-03-28 16:10:06 UTC) #3
Brian Wilkerson
6 years, 9 months ago (2014-03-28 16:15:07 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698