Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 217033005: Updated markdown library. This adds support for images in the doccumentation! (Closed)

Created:
6 years, 8 months ago by caffinatedmonkey
Modified:
6 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updated markdown library. This adds support for images in the doccumentation! Here are the commits from the markdown library. This was a non-breaking change but was versioned incorrectly. See: * https://github.com/dpeek/dart-markdown/pull/10 * https://github.com/dpeek/dart-markdown/issues/11 Committed: https://code.google.com/p/dart/source/detail?r=34525

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed markdown version in pubspec.yaml #

Patch Set 3 : Added myself to AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -39 lines) Patch
M AUTHORS View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M pkg/docgen/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/markdown/lib/src/inline_parser.dart View 4 chunks +69 lines, -36 lines 0 comments Download
M third_party/pkg/markdown/lib/src/util.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/pkg/markdown/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/markdown/test/markdown_test.dart View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caffinatedmonkey
6 years, 8 months ago (2014-03-28 19:47:05 UTC) #1
kevmoo
Fix that one nit and we should be good. Do you have commit access? If ...
6 years, 8 months ago (2014-03-28 19:57:04 UTC) #2
caffinatedmonkey
On 2014/03/28 19:57:04, kevmoo wrote: > Fix that one nit and we should be good. ...
6 years, 8 months ago (2014-03-28 20:16:49 UTC) #3
kevmoo
On 2014/03/28 20:16:49, caffinatedmonkey wrote: > On 2014/03/28 19:57:04, kevmoo wrote: > > Fix that ...
6 years, 8 months ago (2014-03-28 20:39:36 UTC) #4
kevmoo
6 years, 8 months ago (2014-03-28 20:52:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r34525 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698