Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 21699002: annotation with parameters. (Closed)

Created:
7 years, 4 months ago by janicejl
Modified:
7 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
Emily Fortuna, Tate Mandel
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -26 lines) Patch
M pkg/docgen/lib/docgen.dart View 1 2 15 chunks +52 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
janicejl
7 years, 4 months ago (2013-08-02 02:19:23 UTC) #1
Bob Nystrom
https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart#newcode273 pkg/docgen/lib/docgen.dart:273: bool _isPrivate(DeclarationMirror mirror) { I worry about using "private" ...
7 years, 4 months ago (2013-08-02 15:36:04 UTC) #2
janicejl
https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart#newcode273 pkg/docgen/lib/docgen.dart:273: bool _isPrivate(DeclarationMirror mirror) { On 2013/08/02 15:36:04, Bob Nystrom ...
7 years, 4 months ago (2013-08-02 22:08:07 UTC) #3
Bob Nystrom
LGTM!
7 years, 4 months ago (2013-08-02 22:26:05 UTC) #4
janicejl
7 years, 4 months ago (2013-08-02 22:48:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r25751 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698