annotation with parameters.

annotation with parameters.

BUG=
R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25751

[Bob Nystrom, 2013-08-02 15:36:04]

https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:273: bool _isPrivate(DeclarationMirror mirror) {
I worry about using "private" here because this definition is a bit different
from what the language considers "private" to mean. Would _isVisible/_isHidden
work here?

https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:298: });
When you iterate over a sequence and call .add() on a list inside it, that's
often a hint that map() can be used. Try:

var parameterList = annotation.type.variables.values
    .where((e) => e.isFinal)
    .map((e) => e.getField(v.simpleName).reflectee)
    .toList();

https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:736: 'annotations': new List.from(annotations.map((a)
=> a.toMap())),
Instead of new List.from(), use toList():

annotations.map((a) => a.toMap()).toList()

Below too.

https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:960: 'metaparameters': new List.from(parameters)
Why "metaparameters" and not just "parameters"?

Is the new List.from() needed here? If so, why?

[janicejl, 2013-08-02 22:08:07]

https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:273: bool _isPrivate(DeclarationMirror mirror) {
On 2013/08/02 15:36:04, Bob Nystrom wrote:
> I worry about using "private" here because this definition is a bit different
> from what the language considers "private" to mean. Would _isVisible/_isHidden
> work here?

Done.

https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:298: });
On 2013/08/02 15:36:04, Bob Nystrom wrote:
> When you iterate over a sequence and call .add() on a list inside it, that's
> often a hint that map() can be used. Try:
> 
> var parameterList = annotation.type.variables.values
>     .where((e) => e.isFinal)
>     .map((e) => e.getField(v.simpleName).reflectee)
>     .toList();

Done.

https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:736: 'annotations': new List.from(annotations.map((a)
=> a.toMap())),
On 2013/08/02 15:36:04, Bob Nystrom wrote:
> Instead of new List.from(), use toList():
> 
> annotations.map((a) => a.toMap()).toList()
> 
> Below too.

Done.

https://codereview.chromium.org/21699002/diff/3001/pkg/docgen/lib/docgen.dart...
pkg/docgen/lib/docgen.dart:960: 'metaparameters': new List.from(parameters)
On 2013/08/02 15:36:04, Bob Nystrom wrote:
> Why "metaparameters" and not just "parameters"?
> 
> Is the new List.from() needed here? If so, why?

Done.

[Bob Nystrom, 2013-08-02 22:26:05]

LGTM!

[janicejl, 2013-08-02 22:48:57]

Committed patchset #3 manually as r25751 (presubmit successful).