Issue 216933005: Speeding up ElementList.clear & NodeList.clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216933005: Speeding up ElementList.clear & NodeList.clear. (Closed)

Created:
6 years, 9 months ago by blois

Modified:
6 years, 9 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Speeding up ElementList.clear & NodeList.clear. Changes elements.clear() to no longer remove nodes- but this seems like the correct behavior. Can use the nodes.clear() logic for elements if not. BUG=17892 R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=34532

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -12 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		3 chunks	+8 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		4 chunks	+11 lines, -6 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

blois

6 years, 9 months ago (2014-03-28 22:16:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r34532 (presubmit successful).