Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2168203002: Use the package_resolver package. (Closed)

Created:
4 years, 5 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/source_map_stack_trace.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use the package_resolver package. This allows this to be compatible with package specs as well as package directories. See dart-lang/test#327 R=jmesserly@google.com Committed: https://github.com/dart-lang/source_map_stack_trace/commit/b387ce996e831c6e67730a90676f0fa75d13c49a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -20 lines) Patch
M CHANGELOG.md View 1 chunk +11 lines, -0 lines 0 comments Download
M lib/source_map_stack_trace.dart View 3 chunks +37 lines, -15 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download
M test/source_map_stack_trace_test.dart View 3 chunks +56 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 5 months ago (2016-07-21 19:51:06 UTC) #1
Jennifer Messerly
lgtm
4 years, 4 months ago (2016-07-26 01:03:04 UTC) #2
nweiz
4 years, 4 months ago (2016-07-26 01:03:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b387ce996e831c6e67730a90676f0fa75d13c49a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698