Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 21676003: Add method to html_dartium utils to check for NSM errors (Closed)

Created:
7 years, 4 months ago by Jacob
Modified:
7 years, 4 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add method to html_dartium utils to check for NSM errors BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=25741

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jacob
7 years, 4 months ago (2013-08-02 00:54:47 UTC) #1
vsm
Is this to invoke from native code?
7 years, 4 months ago (2013-08-02 04:09:14 UTC) #2
Jacob
On 2013/08/02 04:09:14, vsm wrote: > Is this to invoke from native code? Yes. Here ...
7 years, 4 months ago (2013-08-02 16:54:12 UTC) #3
vsm
lgtm We're using this pattern in a few places, but adding asiva to think about ...
7 years, 4 months ago (2013-08-02 19:58:36 UTC) #4
Jacob
Committed patchset #1 manually as r25741 (presubmit successful).
7 years, 4 months ago (2013-08-02 20:07:04 UTC) #5
siva
On 2013/08/02 19:58:36, vsm wrote: > lgtm > > We're using this pattern in a ...
7 years, 4 months ago (2013-08-02 22:16:55 UTC) #6
Jacob
7 years, 4 months ago (2013-08-02 22:20:26 UTC) #7
Message was sent while issue was closed.
On 2013/08/02 22:16:55, siva wrote:
> On 2013/08/02 19:58:36, vsm wrote:
> > lgtm
> > 
> > We're using this pattern in a few places, but adding asiva to think about
> > whether we should do this kind of thing natively.
> 
> Is this in a hot frequently used path?
> It makes sense to add a native method to the API if it is used a lot.

It is a hot path for the Developer tools and in the near future for JS interop.

Powered by Google App Engine
This is Rietveld 408576698