Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 216723004: Prepare to push another pre-release (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M pkg/code_transformers/pubspec.yaml View 1 chunk +1 line, -1 line 1 comment Download
M pkg/observe/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/pkgbuild.status View 1 chunk +0 lines, -5 lines 3 comments Download
M pkg/polymer/pubspec.yaml View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/polymer_expressions/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/smoke/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/template_binding/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
I plan to first upload, then submit this immediately after, that way the bots can ...
6 years, 9 months ago (2014-03-28 23:29:05 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/216723004/diff/1/pkg/pkgbuild.status File pkg/pkgbuild.status (left): https://codereview.chromium.org/216723004/diff/1/pkg/pkgbuild.status#oldcode18 pkg/pkgbuild.status:18: samples/third_party/todomvc: Fail # Issue 17324 On 2014/03/28 23:29:06, ...
6 years, 9 months ago (2014-03-28 23:36:04 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r34543 (presubmit successful).
6 years, 9 months ago (2014-03-28 23:46:09 UTC) #3
Siggi Cherem (dart-lang)
6 years, 9 months ago (2014-03-28 23:46:51 UTC) #4
Message was sent while issue was closed.
thx!

https://codereview.chromium.org/216723004/diff/1/pkg/pkgbuild.status
File pkg/pkgbuild.status (left):

https://codereview.chromium.org/216723004/diff/1/pkg/pkgbuild.status#oldcode18
pkg/pkgbuild.status:18: samples/third_party/todomvc: Fail # Issue 17324
On 2014/03/28 23:36:04, John Messerly wrote:
> On 2014/03/28 23:29:06, Siggi Cherem (dart-lang) wrote:
> > John - this was no longer failing for me locally.
> > 
> > Maybe this is no longer covered in the bots?
> 
> yeah, it shouldn't be failing, since it's been working in the -dev releases.
Not
> sure what's going on =(

mmm. after uploading the packages this failed again for me, I reverted this line
for now.

Powered by Google App Engine
This is Rietveld 408576698