Issue 216673003: Allow use of [keys] from a map by using different bailout strategy.

Issue 216673003: Allow use of [keys] from a map by using different bailout strategy. (Closed)

Created:
6 years, 9 months ago by herhut

Modified:
6 years, 8 months ago

Reviewers:
karlklose, floitsch

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow use of [keys] from a map by using different bailout strategy. BUG= R=floitsch@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=34726

Patch Set 2 : Karl's comments and some further fixes #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -16 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart	View	1	8 chunks	+57 lines, -5 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart	View		2 chunks	+4 lines, -11 lines	0 comments	Download
A	tests/compiler/dart2js/map_tracer_keys_test.dart	View	1	1 chunk	+78 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM, but can you test this? https://codereview.chromium.org/216673003/diff/20001/sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart File sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart (right): https://codereview.chromium.org/216673003/diff/20001/sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart#newcode243 sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart:243: /* Checks whether ...

6 years, 8 months ago (2014-03-31 14:39:27 UTC) #2

herhut

I have added a test and in the process found a bug. Hooray for tests. ...

6 years, 8 months ago (2014-04-02 13:25:53 UTC) #3

floitsch

Still LGTM. https://codereview.chromium.org/216673003/diff/40001/sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart File sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart (right): https://codereview.chromium.org/216673003/diff/40001/sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart#newcode65 sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart:65: // [keys] only allows key values to ...

6 years, 8 months ago (2014-04-02 16:55:29 UTC) #4

herhut

On 2014/04/02 16:55:29, floitsch wrote: > Still LGTM. > > https://codereview.chromium.org/216673003/diff/40001/sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart > File sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart > ...

6 years, 8 months ago (2014-04-03 07:57:08 UTC) #5

herhut

6 years, 8 months ago (2014-04-04 08:06:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r34726 (presubmit successful).

Expand Messages | Collapse Messages