Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216633003: Version 1.3.0-dev.7.5 (Closed)

Created:
6 years, 9 months ago by ricow1
Modified:
6 years, 9 months ago
Reviewers:
Kasper Lund, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Version 1.3.0-dev.7.5 svn merge -c 34481 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 34484 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 34486 https://dart.googlecode.com/svn/branches/bleeding_edge trunk Use changes to trunk/dart/tests/language/language.status from https://codereview.chromium.org/216383004 cd trunk/dart svn revert tests/language/language.status wget -O diff https://codereview.chromium.org/download/issue216383004_1_10018.diff patch -p0 < diff rm diff R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=34497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -113 lines) Patch
M dart/runtime/lib/corelib_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + dart/runtime/lib/lib_prefix.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M dart/runtime/lib/object.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M dart/runtime/vm/bootstrap_natives.h View 1 chunk +2 lines, -0 lines 0 comments Download
M dart/runtime/vm/compiler.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M dart/runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/vm/object.h View 4 chunks +52 lines, -37 lines 0 comments Download
M dart/runtime/vm/object.cc View 11 chunks +101 lines, -9 lines 0 comments Download
M dart/runtime/vm/object_store.h View 2 chunks +6 lines, -0 lines 0 comments Download
M dart/runtime/vm/object_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M dart/runtime/vm/parser.h View 4 chunks +8 lines, -1 line 0 comments Download
M dart/runtime/vm/parser.cc View 10 chunks +106 lines, -34 lines 0 comments Download
M dart/runtime/vm/raw_object.h View 4 chunks +18 lines, -14 lines 0 comments Download
M dart/runtime/vm/raw_object_snapshot.cc View 2 chunks +5 lines, -1 line 0 comments Download
M dart/runtime/vm/snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/vm/symbols.h View 1 chunk +2 lines, -0 lines 0 comments Download
M dart/tests/language/deferred_constraints_type_annotation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/language.status View 2 chunks +15 lines, -10 lines 0 comments Download
M dart/tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/standalone/issue14236_source.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M dart/tests/standalone/issue14236_test.dart View Binary file 0 comments Download
M dart/tools/VERSION View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
I validated the diff between this and https://codereview.chromium.org/216383004 wget -O rico https://codereview.chromium.org/download/issue216633003_1.diff wget -O ivan ...
6 years, 9 months ago (2014-03-28 10:33:43 UTC) #1
ricow1
6 years, 9 months ago (2014-03-28 10:34:24 UTC) #2
kasperl
LGTM. Thanks, Rico!
6 years, 9 months ago (2014-03-28 10:34:43 UTC) #3
ricow1
6 years, 9 months ago (2014-03-28 10:35:45 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r34497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698