Issue 216553006: pkg/intl: updated for latest unittest deprecations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216553006: pkg/intl: updated for latest unittest deprecations (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 9 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	pkg/intl/pubspec.yaml	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/intl/test/date_time_format_http_request_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/intl/test/find_default_locale_browser_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/intl/test/find_default_locale_standalone_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/intl/test/intl_message_basic_example_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Alan Knight

LGTM for the code changes. For the version I would say either change it to ...

6 years, 9 months ago (2014-03-28 17:51:08 UTC) #2

kevmoo

6 years, 9 months ago (2014-03-28 18:09:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34509 (presubmit successful).