Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2165423002: Add support for Flutter SDK constraints. (Closed)

Created:
4 years, 5 months ago by nweiz
Modified:
4 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for Flutter SDK constraints. We still need to verify that a Flutter SDK constraint is only used with an appropriate Dart SDK constraint. See #1432 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/9a178f3dd4b88bab856ab80b6c52f39e468fa710

Patch Set 1 #

Patch Set 2 : Fix pubspec up-to-date logic. #

Total comments: 4

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -89 lines) Patch
M lib/src/cached_package.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/entrypoint.dart View 1 3 chunks +39 lines, -5 lines 0 comments Download
A lib/src/flutter.dart View 1 chunk +25 lines, -0 lines 0 comments Download
M lib/src/global_packages.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M lib/src/lock_file.dart View 6 chunks +61 lines, -23 lines 0 comments Download
M lib/src/pubspec.dart View 8 chunks +33 lines, -26 lines 0 comments Download
M lib/src/solver/backtracking_solver.dart View 2 chunks +22 lines, -5 lines 0 comments Download
M lib/src/solver/version_solver.dart View 1 chunk +17 lines, -3 lines 0 comments Download
M lib/src/validator/dependency.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/validator/sdk_constraint.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/lock_file_test.dart View 3 chunks +51 lines, -1 line 0 comments Download
M test/must_pub_get_test.dart View 1 2 2 chunks +66 lines, -0 lines 0 comments Download
M test/pubspec_test.dart View 1 chunk +18 lines, -15 lines 0 comments Download
M test/version_solver_test.dart View 4 chunks +167 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nweiz
4 years, 5 months ago (2016-07-21 20:49:09 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/2165423002/diff/20001/test/must_pub_get_test.dart File test/must_pub_get_test.dart (right): https://codereview.chromium.org/2165423002/diff/20001/test/must_pub_get_test.dart#newcode289 test/must_pub_get_test.dart:289: integration("the lock file's Flutter SDK constraint doesn't match ...
4 years, 5 months ago (2016-07-22 00:14:47 UTC) #3
nweiz
Code review changes
4 years, 5 months ago (2016-07-22 00:44:54 UTC) #4
nweiz
https://codereview.chromium.org/2165423002/diff/20001/test/must_pub_get_test.dart File test/must_pub_get_test.dart (right): https://codereview.chromium.org/2165423002/diff/20001/test/must_pub_get_test.dart#newcode289 test/must_pub_get_test.dart:289: integration("the lock file's Flutter SDK constraint doesn't match the ...
4 years, 5 months ago (2016-07-22 00:45:02 UTC) #5
nweiz
4 years, 5 months ago (2016-07-22 00:45:19 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9a178f3dd4b88bab856ab80b6c52f39e468fa710 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698