Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 216233002: pkg/code_transformers: removed unused imports, require latest unittest (Closed)

Created:
6 years, 9 months ago by kevmoo
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/code_transformers: removed unused imports, require latest unittest R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34505

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M pkg/code_transformers/lib/src/resolver_impl.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/code_transformers/pubspec.yaml View 1 chunk +1 line, -1 line 2 comments Download
M pkg/code_transformers/test/assets_test.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/code_transformers/test/entry_point_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/code_transformers/test/resolver_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kevmoo
You aren't using any deprecated features of unittest now -- make sure you don't start.
6 years, 9 months ago (2014-03-28 04:05:26 UTC) #1
Siggi Cherem (dart-lang)
https://codereview.chromium.org/216233002/diff/1/pkg/code_transformers/pubspec.yaml File pkg/code_transformers/pubspec.yaml (right): https://codereview.chromium.org/216233002/diff/1/pkg/code_transformers/pubspec.yaml#newcode12 pkg/code_transformers/pubspec.yaml:12: unittest: ">=0.10.1 <0.11.0" mmm... this will have a cascade ...
6 years, 9 months ago (2014-03-28 16:12:03 UTC) #2
kevmoo
https://codereview.chromium.org/216233002/diff/1/pkg/code_transformers/pubspec.yaml File pkg/code_transformers/pubspec.yaml (right): https://codereview.chromium.org/216233002/diff/1/pkg/code_transformers/pubspec.yaml#newcode12 pkg/code_transformers/pubspec.yaml:12: unittest: ">=0.10.1 <0.11.0" On 2014/03/28 16:12:03, Siggi Cherem (dart-lang) ...
6 years, 9 months ago (2014-03-28 16:24:32 UTC) #3
Siggi Cherem (dart-lang)
On 2014/03/28 16:24:32, kevmoo wrote: > https://codereview.chromium.org/216233002/diff/1/pkg/code_transformers/pubspec.yaml > File pkg/code_transformers/pubspec.yaml (right): > > https://codereview.chromium.org/216233002/diff/1/pkg/code_transformers/pubspec.yaml#newcode12 > ...
6 years, 9 months ago (2014-03-28 16:25:18 UTC) #4
Siggi Cherem (dart-lang)
On 2014/03/28 16:25:18, Siggi Cherem (dart-lang) wrote: > On 2014/03/28 16:24:32, kevmoo wrote: > > ...
6 years, 9 months ago (2014-03-28 16:25:26 UTC) #5
kevmoo
6 years, 9 months ago (2014-03-28 16:31:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r34505 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698